Better defaults for MAPTOOL_DATADIR#5981
Open
kwvanderlinde wants to merge 2 commits into
Open
Conversation
If the user provided it already, we will use the user-provided value. Otherwise, it defaults to `.maptool-rptools`. This is handled in `LaunchInstructions` before anything else happens. In `AppUtil`, the default behaviour when MAPTOOL_DATADIR is missing is to create a local directory instead of using the user's home directory. This covers tests or other development runs that don't go through `LaunchInstructions`.
Operations to resolve paths are now based on `Path` instead of `File` or `String`, and we no longer manually join paths. The higher-level methods still use `File` as it's not worth changing at this point in time.
github-actions
Bot
added
the
code-maintenance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Resolves #5974
Description of the Change
It is no longer required to provide
-DMAPTOOL_DATADIR=.maptool-rptoolsto store MT data under~/.maptool-rptools. The~/.maptooldirectory will never be used as a default anymore. For situations like test runs,AppUtilwill default the data directory to be local to the developmenet directory, under./run/The option is still supported, so users can still redirect the data directory to be in another location.
I changed some of the path handling in
AppUtilto usePathrather than manipulating and joiningString-based orFile-based paths.Possible Drawbacks
Should be none.
Documentation Notes
N/A
Release Notes
MAPTOOL_DATADIRsystem property to be.maptool-rptools.This change is