Fix Edit Table dialog with recent pick-once changes#5984
Open
kwvanderlinde wants to merge 3 commits into
Open
Conversation
…); recalculate row heights on any table change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes #5818
Description of the Change
This fixes regressions in the Edit Table dialog introduced as part of #5868. The images are now displayed consistently (large when one is present), and the buttons now work regardless of whether the table is pick-once.
The buttons were fixed by using the current column index (there was a
getCanonicalColumn()call missing).LookupTableRownow has getters and setters, allowing it to be observed.LookupTableTableModelreacts to changes in itsLookupTableRowto ensure that, among other things, the row height is recalculated as needed.Possible Drawbacks
None
Documentation Notes
N/A
Release Notes
This change is