Add storage integration to CSVConfig#257
Merged
Merged
Conversation
Make CSVConfig.storage_integration optional and parse/print it as a nested
(storage_integration {...}) config_dict. Secret credentials are masked as "***".
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Rename the grammar nonterm to storage_integration so it no longer collides with the auto-generated CSVStorageIntegration message printer, and regenerate the SDK parsers/printers. Add a csv_storage_integration fixture (S3/Azure import + S3 export) plus unit tests covering secret masking. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
comnik
reviewed
Jun 10, 2026
comnik
approved these changes
Jun 10, 2026
comnik
left a comment
comnik
left a comment
Collaborator
There was a problem hiding this comment.
One naming suggestion, otherwise looks good
Rename the grammar nonterm to _storage_integration to avoid colliding with the renamed message's printer, and regenerate the SDKs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds storage integration options for CSVConfig. These allow reading/writing to and from private s3/azure buckets with SAS tokens or private keys etc.