Skip to content

Add paint color customizable addon (suggestion)#49

Open
CnicKTheCrocodile wants to merge 1 commit into
StrataSource:mainfrom
CnicKTheCrocodile:main
Open

Add paint color customizable addon (suggestion)#49
CnicKTheCrocodile wants to merge 1 commit into
StrataSource:mainfrom
CnicKTheCrocodile:main

Conversation

@CnicKTheCrocodile

Copy link
Copy Markdown

I'm submitting a pull request to add my suggestion to the repository.

If you don't have the suggestion details handy, it's posted on the P2:CE Discord here: https://discord.com/channels/663715905267564564/1498297904954343535

Basically, I just made it possible to change particle colors using the *_paint_color commands by applying the "PaintOverlayColor" proxy to each material.

@lenship2 lenship2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the layout of this addon is too messy with the file naming schemes, and that it would be better to consolidate each vmt to a new particles/paint/ folder. There they could also have more appropriate names that aren't inherited from their hl2 counterparts.

Additionally, the colors of a lot of the particles are too bright in comparison to their vanilla versions, which ends up looking really bad in comparison. I think the issue comes from some shaders not supporting 255 color values in their mat proxies; however, this means that some type of modification to how the color change is handled in the addon should probably be done first. You could probably do some basic division proxies to convert the 255 values to a float to fix it.

Here are some comparison screenshots, for reference:
Image
Image

You also shouldn't need shouldAlpha 1 in any of the proxies, but that's just a nitpick and it doesn't really matter here.

Once that's done though, I think I'll be able to just merge this directly into the game.

(also, for future reference, because your addon counts as a map addon rather than an asset addon in the steam workshop, it can't actually be enabled by other users without toggling hidden addons)

@CnicKTheCrocodile

Copy link
Copy Markdown
Author

I was wondering if it would be good to put it in assets but not be able to see the map in single player.

Regarding the addon, I authorize you to modify it to create a perfect version; of course, I've taken the necessary steps to ensure it works in the game.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants