DOCS-1711 - Fix merge window to soft-warn for docs-only PRs in merge queue#6830
Open
kimsauce wants to merge 2 commits into
Open
DOCS-1711 - Fix merge window to soft-warn for docs-only PRs in merge queue#6830kimsauce wants to merge 2 commits into
kimsauce wants to merge 2 commits into
Conversation
…queue The merge_group event path hard-blocked all PRs outside the window regardless of file type. Hoist ARTICLE_PATTERNS and file classification into shared helpers so the merge queue applies the same two-tier policy as the pull_request path: hard-block site changes, soft-warn for docs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
kimsauce
requested review from
JV0812,
amee-sumo,
mafsumo and
vfalconisumo
as code owners
v7 runs on Node.js 20, which is deprecated on GitHub Actions runners now defaulting to Node.js 24. v8 targets Node.js 24 and resolves the deprecation warning on every PR check run. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request fixes two issues with the merge window check in
.github/workflows/pr.yml:Docs-only PRs hard-blocked in merge queue — The
merge_groupevent path was missing the file classification logic present in thepull_requestpath, causing docs-only PRs to be hard-blocked outside the window instead of passing with a soft warning. Fix hoistsARTICLE_PATTERNSand classification into shared helpers used by both paths.Node.js 20 deprecation warning — Bumps
actions/github-scriptfrom v7 (Node.js 20) to v8 (Node.js 24) to resolve deprecation warnings on runners that now default to Node.js 24.Select the type of change
Ticket (if applicable)
https://sumologic.atlassian.net/browse/DOCS-1711
https://sumologic.atlassian.net/browse/DOCS-1712