Zarr bug fix and improvements#1566
Merged
Merged
Conversation
In ZarrLayoutBB, look up each chunk's byte offset directly from chunkStarts to remove dependency on file sort order. Fixes Unidata#1542
The calls to Math.ceil were effectively no-ops, as int/int produces an int, which was then passed to the ceil method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Avoid relying on file sorting order when reading data from a chunk. Instead, look up each chunk's byte offset directly from the new chunkStarts to remove dependency on file sort order. Fixes #1542.
Additionally, fix a bug related to computing the number of chunks in a dimension (calls to Math.ceil were effectively no-ops, as int/int produces an
int, which was then passed to the ceil method.)
PR Checklist
until ready for review