Skip to content

NEW: Add more genre-style tests for the input consumption rework#2430

Merged
K-Tone merged 6 commits into
developfrom
anthony/input-consumption-genre-tests
Jun 9, 2026
Merged

NEW: Add more genre-style tests for the input consumption rework#2430
K-Tone merged 6 commits into
developfrom
anthony/input-consumption-genre-tests

Conversation

@K-Tone

@K-Tone K-Tone commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Description

These are the genre-style tests that didn't make it into the main branch when we landed the new input consumption thing. They were originally part of a separate private repo where the demo project lived, and then we moved them to this repository.

Related to https://jira.unity3d.com/browse/ISX-2544

Testing status & QA

Doesn't require extra testing work, it's just tests - if it passed CI then it's good.

Overall Product Risks

  • Complexity: Low
  • Halo Effect: Low

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

@u-pr u-pr Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

The tests for input consumption genres are well-structured, though a few minor inconsistencies in state updates and assertion coverage should be addressed.

🤖 Helpful? 👍/👎

Comment thread Assets/Tests/InputSystem/CoreTests_ActionPriority_Genres.cs
Comment thread Assets/Tests/InputSystem/CoreTests_ActionPriority_Genres.cs
@K-Tone K-Tone changed the title Anthony/input consumption genre tests NEW: Add more genre-style tests for the input consumption rework Jun 8, 2026
@K-Tone K-Tone requested a review from Darren-Kelly-Unity June 8, 2026 17:03
@codecov-github-com

codecov-github-com Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

@@             Coverage Diff              @@
##           develop    #2430       +/-   ##
============================================
+ Coverage    58.58%   79.01%   +20.43%     
============================================
  Files          738      765       +27     
  Lines       135831   140341     +4510     
============================================
+ Hits         79570   110889    +31319     
+ Misses       56261    29452    -26809     
Flag Coverage Δ
inputsystem_MacOS_6000.0 5.31% <ø> (ø)
inputsystem_MacOS_6000.0_project 77.47% <100.00%> (+0.22%) ⬆️
inputsystem_MacOS_6000.3 5.31% <ø> (ø)
inputsystem_MacOS_6000.3_project 77.46% <100.00%> (+0.24%) ⬆️
inputsystem_MacOS_6000.4 5.32% <ø> (ø)
inputsystem_MacOS_6000.4_project 77.48% <100.00%> (+0.24%) ⬆️
inputsystem_MacOS_6000.5 5.31% <ø> (ø)
inputsystem_MacOS_6000.5_project 77.51% <100.00%> (+0.25%) ⬆️
inputsystem_MacOS_6000.6 5.31% <ø> (ø)
inputsystem_MacOS_6000.6_project 6.59% <0.00%> (-70.67%) ⬇️
inputsystem_Ubuntu_6000.0 5.32% <ø> (ø)
inputsystem_Ubuntu_6000.0_project 77.38% <100.00%> (+0.22%) ⬆️
inputsystem_Ubuntu_6000.3 5.32% <ø> (ø)
inputsystem_Ubuntu_6000.3_project 77.37% <100.00%> (+0.24%) ⬆️
inputsystem_Ubuntu_6000.4 5.32% <ø> (ø)
inputsystem_Ubuntu_6000.4_project 77.38% <100.00%> (+0.25%) ⬆️
inputsystem_Ubuntu_6000.5 5.31% <ø> (ø)
inputsystem_Ubuntu_6000.5_project 77.42% <100.00%> (+0.25%) ⬆️
inputsystem_Ubuntu_6000.6 5.31% <ø> (ø)
inputsystem_Ubuntu_6000.6_project 6.55% <0.00%> (-70.62%) ⬇️
inputsystem_Windows_6000.0 5.31% <ø> (ø)
inputsystem_Windows_6000.0_project 77.59% <100.00%> (+0.21%) ⬆️
inputsystem_Windows_6000.3 5.31% <ø> (ø)
inputsystem_Windows_6000.3_project 77.59% <100.00%> (+0.24%) ⬆️
inputsystem_Windows_6000.4 5.32% <ø> (ø)
inputsystem_Windows_6000.4_project 77.59% <100.00%> (+0.24%) ⬆️
inputsystem_Windows_6000.5 5.31% <ø> (ø)
inputsystem_Windows_6000.5_project 77.64% <100.00%> (+0.24%) ⬆️
inputsystem_Windows_6000.6 5.31% <ø> (ø)
inputsystem_Windows_6000.6_project 0.00% <0.00%> (-77.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...sts/InputSystem/CoreTests_ActionPriority_Genres.cs 100.00% <100.00%> (ø)

... and 279 files with indirect coverage changes

ℹ️ Need help interpreting these results?

K-Tone and others added 2 commits June 8, 2026 21:32
Co-authored-by: u-pr[bot] <205906871+u-pr[bot]@users.noreply.github.com>
Co-authored-by: u-pr[bot] <205906871+u-pr[bot]@users.noreply.github.com>
@K-Tone

K-Tone commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator Author

After looking at these failures and rerunning them, one passed. There are a few where the reason is Failed to deserialize UTP message due to value exceeding limit which is unrelated to this PR. The sample project one appears to be some timeout issue. The dry run issue is something else mysterious but also unrelated most likely. That said, I'm bypassing rules and merging it to communicate the epic is over really.

@K-Tone K-Tone merged commit 71e571f into develop Jun 9, 2026
98 of 107 checks passed
@K-Tone K-Tone deleted the anthony/input-consumption-genre-tests branch June 9, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants