Implement progress indicator#33
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…tself.. Not sure about all the move/forward stuff
… incomplete read.
|
The indicator feature is functional! I'll need to do some error handling, not quite sure how to do that to be honest... Probably some static assert, since it's almost all template stuff. plus I'm unsure of how to do the testing part. I added the indicator in the reader integration test and it's all covered, but I think it might be necessary to implement unit tests as well. |
|
Thanks for the PR. I will check the code in detail later.
Yeah, static checking should always be preferred.
I would say an integration test should suffice. |
Adding p-ranav/indicators library to this project, to indicate the reader status. (and any other range object)