Fix get_data_from_manifests returning wrong type on early exit#2182
Open
prajakta128 wants to merge 1 commit into
Open
Fix get_data_from_manifests returning wrong type on early exit#2182prajakta128 wants to merge 1 commit into
prajakta128 wants to merge 1 commit into
Conversation
prajakta128
force-pushed
the
fix/get-data-from-manifests-inconsistent-return-type
branch
2 times, most recently
from
64e8a8a to
c8b1677
Compare
When manifest_resources is empty, the function returned a bare []
instead of ([], []). All callers unpack the result as a two-tuple:
packages, dependencies = get_data_from_manifests(...)
This caused a ValueError crash in the LoadSBOM and
ResolveDependencies pipelines when no manifest resources exist.
Fix: return [], [] to match the expected return type consistently.
Add a regression test to verify the function always returns a tuple.
Signed-off-by: Prajakta Kamble <prajuu2812@gmail.com>
prajakta128
force-pushed
the
fix/get-data-from-manifests-inconsistent-return-type
branch
from
c8b1677 to
52a51e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix
get_data_from_manifestsreturning a bare[]instead of([], [])when no manifest resources exist.Why
All callers unpack the return value as a two-tuple:
This is done in two pipelines:
scanpipe/pipelines/load_sbom.pyline 59scanpipe/pipelines/resolve_dependencies.pyline 87When
manifest_resources.exists()is False, the function hit:This causes a
ValueError: not enough values to unpackcrash, crashing the entire LoadSBOM and ResolveDependencies pipelineswhenever a project has no manifest resources.
Fix
One character change in
scanpipe/pipes/resolve.py:Added a regression test to verify the function always returns a two-tuple even when manifest_resources is empty.