fix(knowledge): inject drift findings into coder sessions (fixes #671)#673
Open
mickume wants to merge 1 commit into
Open
fix(knowledge): inject drift findings into coder sessions (fixes #671)#673mickume wants to merge 1 commit into
mickume wants to merge 1 commit into
Conversation
Drift findings from drift-review sessions were stored in drift_findings but never injected into downstream coder sessions via the FoxKnowledgeProvider. Only review findings were queried and tracked. Added _query_drift() to FoxKnowledgeProvider that queries query_active_drift_findings() and merges results into retrieve() alongside review findings. Both share the same max_items cap and finding_injections tracking. Updated supersede_injected_findings() to UPDATE both review_findings and drift_findings tables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drift findings from drift-review sessions were stored but never injected into downstream coder sessions. Coders independently rediscovered issues the drift reviewer had already found.
Closes #671
Changes
packages/agentfox/agentfox/knowledge/fox_provider.py_query_drift(), wired intoretrieve()alongside review findingspackages/agentfox/agentfox/knowledge/review_store.pysupersede_injected_findings()now UPDATEs bothreview_findingsanddrift_findingspackages/agentfox/agentfox/knowledge/formatting.pyformat_drift_finding_parts()for drift-specific fieldspackages/agentfox/tests/spec/test_10_fox_provider_cleanup.pyVerification
Auto-generated by
af-fix.