Return userid from check_permission#948
Open
Maillol wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #948 +/- ##
==========================================
+ Coverage 94.13% 94.19% +0.05%
==========================================
Files 11 11
Lines 597 620 +23
Branches 30 22 -8
==========================================
+ Hits 562 584 +22
- Misses 26 27 +1
Partials 9 9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Vizonex
suggested changes
Apr 11, 2026
|
|
||
| If user is not authorized - raises HTTPUnauthorized, | ||
| if user is authorized and does not have permission - | ||
| raises HTTPForbidden. |
Member
There was a problem hiding this comment.
I would recommend putting down what this function returns into the docstring but besides that that's really the only thing I could see as being a possible nitpick for anyone else reviewing this.
Suggested change
| raises HTTPForbidden. | |
| raises HTTPForbidden on failure, and returns the user id on success. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
check_permissionnow returns the userid instead of None.This avoids an extra authorization lookup for callers.
Are there changes in behavior for the user?
These changes does not break existing logic (only adds a returned value)
Related issue number
Checklist