This repository was archived by the owner on Oct 2, 2019. It is now read-only.
Fix: Search box not shown to search when data is an empty array with select2 theme#2099
Open
Sparksx wants to merge 1 commit into
Open
Fix: Search box not shown to search when data is an empty array with select2 theme#2099Sparksx wants to merge 1 commit into
Sparksx wants to merge 1 commit into
Conversation
Contributor
|
Please clean up the dist |
Author
|
dist cleaned |
Author
|
After more investigation, lot of problems come from empty array set and $animate event. We need to investigate more about that |
Contributor
|
@Sparksx do you want to investigate a bit more on how to resolve the animation problem? Next , thanks for the PR could you explain if this problem is only present in the select2 theme? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1805
Juste fork, fix into
src/uiSelectDirective.jsand build