fix: isolate anonymous file statistics cache#22950
Open
kumarUjjawal wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
ProjectionExprs::project_statisticsindex out of bounds #22935.Rationale for this change
Anonymous file reads can read the same path with different explicit schemas in the same session. The shared file statistics cache was keyed by table/path metadata, but did not validate that cached statistics matched the schema used to compute them.
This could reuse narrower cached statistics for a later wider schema read and panic during statistics projection.
What changes are included in this PR?
This PR routes anonymous listing table statistics through a per-table cache instead of the shared session cache.
Named tables still use the shared session cache, since their table reference gives the cache a stable identity.
It also adds a regression test that first warms statistics with the physical schema, then reads the same Parquet file with a wider explicit schema.
Are these changes tested?
Yes
Are there any user-facing changes?
No API Change