GH 1361 Respect the filterFunctors flag during backward chaining#4022
Merged
Conversation
afs
approved these changes
Jun 27, 2026
Member
|
Keeping the test as-is is fine. It uses the same reasoner rather than creates a new one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub issue resolved #1361
Pull request Description:
#1361 mentions a bug where the filtered function flag wasn't being respected when backward chaining. The author fortunately outlined the places in the forward chaining path where it's respected - so adding them to the backward path was fairly straight forward. This shouldn't have any weird side effects but I haven't used the reasoner with custom filters before looking into this ticket.
In terms of testing I added a unit test that checks the filter present/absent based on the new boolean flag. If you'd like this unit test to be split into two, just let me know and I'll push another commit with the changes.
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.
See the Apache Jena "Contributing" guide.