SWIP-15: add BanyanDB queue batch/message metrics (apache/skywalking-banyandb#1169)#13904
Merged
Merged
Conversation
wankai123
previously approved these changes
Jun 11, 2026
a2a85cc to
541e83f
Compare
wankai123
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surface BanyanDB queue batch / message granularity metrics (apache/skywalking-banyandb#1169)
Follow-up to the SWIP-15 BanyanDB self-observability redesign. BanyanDB PR #1169 added per-batch and per-message catalogs to the batch-write queue metrics; this PR surfaces the subset that genuinely populates, modeled per the cluster / container / group scopes.
docs/en/banyandb/dashboards-banyandb.md— added the new metric rows under the Liaison / Data / Endpoint tables.test/e2e-v2/cases/banyandb/banyandb-cases.yaml); MAL fixture coverage regenerated. Verified locally: e2e 20/20 passed on a clean OAP image against a BanyanDB 0.11 (apache/skywalking-banyandb#1169) cluster (liaison + hot data);MALExpressionExecutionTest0 banyandb failures.New metrics (5 — all e2e-verified to return data)
publish_batch_throughputbanyandb_queue_pub_total_batch_finishedpublish_batch_latency_p99banyandb_queue_pub_total_batch_latencyqueue_sub_message_throughputbanyandb_queue_sub_total_message_finishedqueue_batch_throughputbanyandb_queue_sub_total_batch_finishedqueue_message_throughputbanyandb_queue_sub_total_message_finishedIntentionally not modeled (verified empty-by-design)
Confirmed by probing a live BanyanDB 0.11 cluster and reading the BanyanDB source:
queue_sub_batch_throughput/queue_sub_batch_latency_p99at instance/data scope — a data node ingests writes via the per-message dispatch path, which ticks only the message counter; the sub-side batch counters fire on the liaison's OAP-facinghandleEOFhop, so they are always empty on a data node.queue_batch_latency_p99at endpoint scope —banyandb_queue_pub_total_batch_latencyis emitted withgroup="", so it cannot roll up per Endpoint (it is meaningful only at instance scope, wherepublish_batch_latency_p99covers it).Other changes
test/e2e-v2/script/env: bumpSW_BANYANDB_COMMITto the feat(queue): add message + batch unit catalogs to batch-write metrics skywalking-banyandb#1169 merge commit (the one that ships these families). The diff from the previous pin is docs + the additive metrics PR + an off-path lifecycle/dump refactor; the full write/query path is exercised green by the so11y e2e, and CI runs the full banyandb e2e matrix.Update the
CHANGESlog.