[ZEPPELIN-6555] Avoid deadlock in ManagedInterpreterGroup.close() by not holding the group lock while closing session interpreters#5329
Open
hyunw9 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
ManagedInterpreterGroup.close()can deadlock with a concurrentRemoteInterpreter.open()because the two paths take the same two monitors in the opposite order.Two monitors are involved: the interpreter-group monitor and an individual interpreter's monitor.
open()takes the interpreter monitor first (synchronized(this)) and then the group monitor (viagetOrCreateSession()and the angular-registry push). Order: interpreter → group.close(String)is asynchronizedmethod, so it holds the group monitor while it spawns the per-interpreter close threads andjoin()s them. Each close thread runsinterpreter.close(), which takes the interpreter monitor. Order: group → interpreter.So when an interpreter is opened while its session is concurrently closed (for example, restarting or shutting down an interpreter while a paragraph on that session is still starting up), the two orders form a circular wait.
What type of PR is it?
Bug Fix
Todos
close(String)ManagedInterpreterGroupTest#close_doesNotDeadlockWithConcurrentOpenWhat is the Jira issue?
[ZEPPELIN-6555]
How should this be tested?
ManagedInterpreterGroupTest#close_doesNotDeadlockWithConcurrentOpen.Screenshots (if appropriate)
Questions: