fix: import FileSystem expo-file-system/legacy (react-native)#1691
Open
bhardwajparth51 wants to merge 2 commits into
Open
fix: import FileSystem expo-file-system/legacy (react-native)#1691bhardwajparth51 wants to merge 2 commits into
bhardwajparth51 wants to merge 2 commits into
Conversation
Contributor
Greptile SummaryUpdates generated React Native services to use Expo’s legacy file-system export and adds the corresponding Rollup test alias.
Confidence Score: 5/5The PR appears safe to merge. The added exact-match Rollup alias addresses the previously reported shim bypass, and no blocking failure remains. Important Files Changed
Reviews (2): Last reviewed commit: "test(react-native): update rollup alias ..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Problem & Fix
In Expo SDK 55 (
expo-file-system@55.x), Expo moved legacy file system methods likereadAsStringAsyncandwriteAsStringAsyncto theexpo-file-system/legacysubpath export.Importing
readAsStringAsyncdirectly from top-levelexpo-file-systemcauses runtime crashes during chunked file uploads (> 5MB) on Expo SDK 55 applications.This PR updates the template import in
templates/react-native/src/services/template.ts.twigto import fromexpo-file-system/legacy, restoring compatibility for file uploads on Expo SDK 55.Relates to appwrite/sdk-for-react-native#112