Skip to content

fix: EventBridgeEvent data class#8301

Merged
leandrodamascena merged 7 commits into
aws-powertools:developfrom
amin-farjadi:fix/event-bridge-event-model
Jul 2, 2026
Merged

fix: EventBridgeEvent data class#8301
leandrodamascena merged 7 commits into
aws-powertools:developfrom
amin-farjadi:fix/event-bridge-event-model

Conversation

@amin-farjadi

@amin-farjadi amin-farjadi commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Issue number: closes #8300

Summary

Changes

replay-name field only exists for replay events and, is an optional field. Updated EventBridgeEvent data class to reflect that.

User experience

This change is backwards compatible. Going forward, users can use the EventBridgeEvent class for event sourcing non-replayed events.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@amin-farjadi amin-farjadi requested a review from a team as a code owner June 24, 2026 10:17
@boring-cyborg boring-cyborg Bot added the tests label Jun 24, 2026
@powertools-for-aws-oss-automation powertools-for-aws-oss-automation Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 24, 2026
@amin-farjadi amin-farjadi force-pushed the fix/event-bridge-event-model branch from 4b7fcc8 to e3327fa Compare June 24, 2026 10:30
@powertools-for-aws-oss-automation powertools-for-aws-oss-automation Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 24, 2026

@leandrodamascena leandrodamascena left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment: #8300 (comment)

@powertools-for-aws-oss-automation powertools-for-aws-oss-automation Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 24, 2026
@powertools-for-aws-oss-automation powertools-for-aws-oss-automation Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 25, 2026
@powertools-for-aws-oss-automation powertools-for-aws-oss-automation Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 25, 2026

@leandrodamascena leandrodamascena left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @amin-farjadi there are some errors in the tests, can you check pls?

@powertools-for-aws-oss-automation powertools-for-aws-oss-automation Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 2, 2026
@powertools-for-aws-oss-automation powertools-for-aws-oss-automation Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 2, 2026
@sonarqubecloud

sonarqubecloud Bot commented Jul 2, 2026

Copy link
Copy Markdown

@mergify

mergify Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.63%. Comparing base (f8c7faf) to head (b28028b).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8301   +/-   ##
========================================
  Coverage    96.63%   96.63%           
========================================
  Files          296      296           
  Lines        14689    14689           
  Branches      1231     1231           
========================================
  Hits         14194    14194           
  Misses         360      360           
  Partials       135      135           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leandrodamascena leandrodamascena merged commit 5535469 into aws-powertools:develop Jul 2, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: EventBridgeEvent dataclass has optional fields as compulsory

3 participants