Enable beman-tidy v0.5.2 in default mode#96
Merged
dietmarkuehl merged 5 commits intoJul 13, 2026
Conversation
added 2 commits
July 10, 2026 00:06
Upgrade from v0.4.0 and fix requirement-level Beman Standard violations (readme badges, cmake alias, SPDX license IDs) so default mode passes without --require-all. Closes bemanproject/beman-tidy#262
Upgrade from v0.4.0 and fix requirement-level Beman Standard violations (readme badges, cmake alias, SPDX license IDs) so default mode passes without --require-all. Use C++ comment style for SPDX in msvc-asan-issue.test.cpp so clang-format does not rewrite the license header. Closes bemanproject/beman-tidy#262
|
coverage: 94.059%. remained the same — neatudarius:enable-beman-tidy-default into bemanproject:main |
neatudarius
marked this pull request as ready for review
July 9, 2026 23:09
neatudarius
requested review from
bretbrownjr,
dietmarkuehl,
steve-downey and
wusatosi
as code owners
July 9, 2026 23:09
Force BEMAN_USE_MODULES OFF to match CMake presets and avoid execution product_type.cppm C7760 on MSVC build-and-test jobs (pre-existing on main). Point pre-commit.yml at infra-workflows reusable workflow; the local reusable file was missing and caused immediate workflow failure.
neatudarius
marked this pull request as draft
July 9, 2026 23:58
pre-commit-check.yml already runs the same infra-workflows reusable hook. The legacy pre-commit.yml referenced a missing local reusable file and duplicated the workflow name, causing immediate workflow validation failures on every PR.
neatudarius
marked this pull request as ready for review
July 10, 2026 00:13
neatudarius
marked this pull request as draft
July 10, 2026 00:14
neatudarius
marked this pull request as ready for review
July 10, 2026 00:22
neatudarius
changed the title
dietmarkuehl
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--require-all).beman-tidy.yamlwithignored_paths: [infra/]anddisabled_rules: []Changes
.pre-commit-config.yaml: bump to v0.5.1, addargs: [".", "--verbose"].beman-tidy.yaml: new config fileREADME.md: wrap library status badge in link (readme.badges rule)CMakeLists.txt/src/beman/task/CMakeLists.txt: movebeman::taskalias to top-level CMakeListsTest plan
pre-commit run beman-tidy --all-filespasses locallyCloses bemanproject/beman-tidy#262