Rework the lighthouse geometry estimator#747
Draft
krichardsson wants to merge 93 commits into
Draft
Conversation
krichardsson
changed the title
# Conflicts: # src/cfclient/ui/tabs/lighthouse_tab.py
…crazyflie disconnection
…ples used in the geometry estimation. Updated the lighthouse tab doc.
enyanil
requested changes
Jul 2, 2026
enyanil
left a comment
enyanil
left a comment
Member
There was a problem hiding this comment.
Very nice updates, easy to follow and descriptive! I added comments with my opinions if there are changes you want to implement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains changes that aims at reworking the lighthouse geometry estimator to make it easier to use and help the use to better understand the state of the system.
This is work in progress.
This PR breaks APIs and it should be used together with PR bitcraze/crazyflie-lib-python#543 in the client.