MPS: improved backend#1983
Merged
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
@matthewdouglas are you planning the optimizer support yourself, or is it up for grabs? Happy to take it on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the MPS backend usable without the
kernels-community/bitsandbytes-mpshub kernel - either because the user is on macOS < 26, doesn't have kernels installed, the hub kernel lacks support for the shape/blocksize, or the hub kernel fails to load for any reason. Previously it was not usable in these situations.Changes:
At this point, MPS works with all of the 4bit or LLM.int8() configurations. All tests pass on M4 + macOS 15, with exception of the optimizer support, which will be a future PR.
The MPS path in general requires torch >= 2.9, and for the hub kernels will currently require torch 2.10-2.12. Documentation updates regarding this will be addressed in a future PR.