Skip to content

feat(prow): adding 1.36 jobs for testing#1172

Merged
cert-manager-prow[bot] merged 1 commit into
cert-manager:masterfrom
hjoshi123:feat/k8s-1-36-test-job
Jun 12, 2026
Merged

feat(prow): adding 1.36 jobs for testing#1172
cert-manager-prow[bot] merged 1 commit into
cert-manager:masterfrom
hjoshi123:feat/k8s-1-36-test-job

Conversation

@hjoshi123

Copy link
Copy Markdown
Contributor

No description provided.

@cert-manager-prow cert-manager-prow Bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 23, 2026

@erikgb erikgb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm.

But I am pretty sure this will fail until we have kind images for K8s 1.36, ref. https://github.com/cert-manager/cert-manager/blob/59d77cbfb759f9c9e97599cf863572c0f6fb069c/make/kind_images.sh#L17-L21 🤔 Should we wait until a new kind release is available?

@hjoshi123

Copy link
Copy Markdown
Contributor Author

Yes probably.. there may be no point to merge this until we have a release to test this in a PR.

Comment thread config/prowgen/prowspecs/specs.go Outdated
@erikgb

erikgb commented Jun 2, 2026

Copy link
Copy Markdown
Member

@hjoshi123, I think we can merge this now, as a new version of kind (with images) is available, ref. https://github.com/cert-manager/cert-manager/pull/8839/changes. But before we do, I think we need to remove K8s 1.32.

@hjoshi123 hjoshi123 force-pushed the feat/k8s-1-36-test-job branch from fd110ed to 1c741bc Compare June 11, 2026 20:37
@cert-manager-prow cert-manager-prow Bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 11, 2026
Signed-off-by: hjoshi123 <mail@hjoshi.me>
Signed-off-by: hjoshi123 <hemant.joshi@vizio.com>
@hjoshi123 hjoshi123 force-pushed the feat/k8s-1-36-test-job branch from 1c741bc to 437b5f4 Compare June 11, 2026 20:40
@cert-manager-prow cert-manager-prow Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 11, 2026

@SgtCoDFish SgtCoDFish left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thank you!

@cert-manager-prow cert-manager-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2026
@cert-manager-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2026
@cert-manager-prow cert-manager-prow Bot merged commit 725b077 into cert-manager:master Jun 12, 2026
6 checks passed
@cert-manager-prow

Copy link
Copy Markdown
Contributor

@hjoshi123: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key cert-manager-master.yaml using file config/jobs/cert-manager/cert-manager/master/cert-manager-master.yaml
Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants