Skip to content

Migrate to maintained Go YAML#1213

Merged
cert-manager-prow[bot] merged 1 commit into
cert-manager:masterfrom
erikgb:migrate-yaml-dep
Jun 16, 2026
Merged

Migrate to maintained Go YAML#1213
cert-manager-prow[bot] merged 1 commit into
cert-manager:masterfrom
erikgb:migrate-yaml-dep

Conversation

@erikgb

@erikgb erikgb commented Jun 16, 2026

Copy link
Copy Markdown
Member

#1196 has been annoying me for a while, and I don't want to see it anymore. Suggesting migrating to the maintained fork of YAML support in Go: https://github.com/yaml/go-yaml

@cert-manager-prow cert-manager-prow Bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 16, 2026
@erikgb erikgb force-pushed the migrate-yaml-dep branch 2 times, most recently from e8c01ec to 9e4eb19 Compare June 16, 2026 19:08
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
@erikgb erikgb force-pushed the migrate-yaml-dep branch from 9e4eb19 to e7bc11f Compare June 16, 2026 19:11
@cert-manager-prow cert-manager-prow Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 16, 2026
@erikgb

erikgb commented Jun 16, 2026

Copy link
Copy Markdown
Member Author

/cc @wallrj

@cert-manager-prow cert-manager-prow Bot requested a review from wallrj June 16, 2026 19:13
@wallrj

wallrj commented Jun 16, 2026

Copy link
Copy Markdown
Member

/approve
/lgtm

@cert-manager-prow cert-manager-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2026
@cert-manager-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2026
@cert-manager-prow cert-manager-prow Bot merged commit 8cb7bba into cert-manager:master Jun 16, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants