fix: ensure public key signatures are not in the past compared to the public key#8397
Merged
Conversation
link2xt
force-pushed
the
link2xt/ultxzussxnkk
branch
from
9c54d03 to
7d60e17
Compare
iequidoo
approved these changes
Jul 3, 2026
… public key We use the timestamp of the latest transport modification as the timestamp of the Direct Key Signature. However, first transport is created before the public key and existing transports may even have zero timestamp if they were created before migration 142. For interoperability with Sequoia-PGP, make sure signatures always have a timestamp that is not in the past compared to the timestamp of the primary key.
link2xt
force-pushed
the
link2xt/ultxzussxnkk
branch
from
7d60e17 to
47193f7
Compare
Collaborator
Author
|
Added (previously failing) test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use the timestamp of the latest transport modification as the timestamp of the Direct Key Signature.
However, first transport is created before the public key and existing transports may even have zero timestamp if they were created before migration 142.
For interoperability with Sequoia-PGP,
make sure signatures always have a timestamp
that is not in the past compared to the timestamp
of the primary key.
Closes #8383