Skip to content

refactor: Public types restructuring, part 1#4646

Open
pan-kot wants to merge 6 commits into
mainfrom
refactor-public-interfaces-1
Open

refactor: Public types restructuring, part 1#4646
pan-kot wants to merge 6 commits into
mainfrom
refactor-public-interfaces-1

Conversation

@pan-kot

@pan-kot pan-kot commented Jun 18, 2026

Copy link
Copy Markdown
Member

Description

This PR lifts shared public types to the src/types folder - thus helping to make the separation between public and internal types clearer. In the follow-up PRs I will also remove all internal types from the public paths and establish a contract to be used by all component repositories (secured with ESLint rules).

Rel: D475262969, iu7zAZtdKN3Z

How has this been tested?

  • Dry-run to live
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.51%. Comparing base (c212551) to head (b3ca2d9).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4646   +/-   ##
=======================================
  Coverage   97.51%   97.51%           
=======================================
  Files         948      948           
  Lines       30353    30353           
  Branches    11066    11066           
=======================================
  Hits        29600    29600           
  Misses        746      746           
  Partials        7        7           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pan-kot pan-kot force-pushed the refactor-public-interfaces-1 branch from 03a8f11 to b3ca2d9 Compare June 19, 2026 08:37
@pan-kot pan-kot marked this pull request as ready for review June 19, 2026 09:35
@pan-kot pan-kot requested a review from a team as a code owner June 19, 2026 09:35
@pan-kot pan-kot requested review from srungta08 and removed request for a team June 19, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant