refactor: Public types restructuring, part 1#4646
Open
pan-kot wants to merge 6 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4646 +/- ##
=======================================
Coverage 97.51% 97.51%
=======================================
Files 948 948
Lines 30353 30353
Branches 11066 11066
=======================================
Hits 29600 29600
Misses 746 746
Partials 7 7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
f8b1bbe to
b4501ac
Compare
3ca8119 to
03a8f11
Compare
03a8f11 to
b3ca2d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR lifts shared public types to the src/types folder - thus helping to make the separation between public and internal types clearer. In the follow-up PRs I will also remove all internal types from the public paths and establish a contract to be used by all component repositories (secured with ESLint rules).
Rel: D475262969, iu7zAZtdKN3Z
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.