Skip to content

chore: Update one-theme button-link and alert styles#4651

Merged
at-susie merged 3 commits into
mainfrom
onetheme/alignment-issue
Jun 19, 2026
Merged

chore: Update one-theme button-link and alert styles#4651
at-susie merged 3 commits into
mainfrom
onetheme/alignment-issue

Conversation

@at-susie

Copy link
Copy Markdown
Member

Description

This PR 1) removes opacity from the alert background that caused accessibility color contrast issue when they are displayed on a gradient background, 2) updates button-link link component style for one-theme.

These changes make visual changes only for one-theme.

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Comment thread src/link/internal.tsx
const { defaultVariant } = useContext(LinkDefaultVariantContext);
const variant = providedVariant || defaultVariant;
const specialStyles = ['top-navigation', 'link', 'recovery'];
const specialStyles = ['top-navigation', 'link', 'recovery', 'info'];

@at-susie at-susie Jun 19, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding info here is an intentional general fix, not a one-theme regression.

.button overrides .variant-infos color in the CSS cascade regardless of theme. In visual-refresh, both tokens happen to resolve to the same blue, so the bug is invisible, but it's always there. Excluding info from applyButtonStyles is the correct fix.

@at-susie at-susie requested a review from YueyingLu June 19, 2026 10:14
@at-susie at-susie marked this pull request as ready for review June 19, 2026 10:14
@at-susie at-susie requested a review from a team as a code owner June 19, 2026 10:14
@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.51%. Comparing base (b24a0ee) to head (02243b5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4651   +/-   ##
=======================================
  Coverage   97.51%   97.51%           
=======================================
  Files         948      948           
  Lines       30361    30361           
  Branches    11073    11073           
=======================================
  Hits        29608    29608           
  Misses        746      746           
  Partials        7        7           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@at-susie at-susie added this pull request to the merge queue Jun 19, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 19, 2026
@at-susie at-susie added this pull request to the merge queue Jun 19, 2026
Merged via the queue into main with commit 2b70f2e Jun 19, 2026
51 checks passed
@at-susie at-susie deleted the onetheme/alignment-issue branch June 19, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants