chore: Update one-theme button-link and alert styles#4651
Merged
Conversation
at-susie
commented
Jun 19, 2026
| const { defaultVariant } = useContext(LinkDefaultVariantContext); | ||
| const variant = providedVariant || defaultVariant; | ||
| const specialStyles = ['top-navigation', 'link', 'recovery']; | ||
| const specialStyles = ['top-navigation', 'link', 'recovery', 'info']; |
Member
Author
There was a problem hiding this comment.
Adding info here is an intentional general fix, not a one-theme regression.
.button overrides .variant-infos color in the CSS cascade regardless of theme. In visual-refresh, both tokens happen to resolve to the same blue, so the bug is invisible, but it's always there. Excluding info from applyButtonStyles is the correct fix.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4651 +/- ##
=======================================
Coverage 97.51% 97.51%
=======================================
Files 948 948
Lines 30361 30361
Branches 11073 11073
=======================================
Hits 29608 29608
Misses 746 746
Partials 7 7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
YueyingLu
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR 1) removes opacity from the alert background that caused accessibility color contrast issue when they are displayed on a gradient background, 2) updates button-link link component style for one-theme.
These changes make visual changes only for one-theme.
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.