sql: reject WITHIN GROUP on non-ordered-set aggregates#171369
Open
virajchogle wants to merge 1 commit into
Open
sql: reject WITHIN GROUP on non-ordered-set aggregates#171369virajchogle wants to merge 1 commit into
virajchogle wants to merge 1 commit into
Conversation
WITHIN GROUP (ORDER BY ...) was silently ignored on non-ordered-set functions. Match PostgreSQL by rejecting with SQLSTATE 42809. Fixes cockroachdb#171236 Release note (bug fix): WITHIN GROUP on a function that is not an ordered-set aggregate now returns an error matching PostgreSQL.
Contributor
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #171236
WITHIN GROUP (ORDER BY ...)is only valid on ordered-set aggregate functions (percentile_disc,percentile_cont). CockroachDB silently ignored the clause on general aggregates (sum,avg, ...) and non-aggregate scalar functions (concat_ws,abs, ...), diverging from PostgreSQL's behavior.This rejects the misuse in
scope.VisitPreagainst theisOrderedSetAggregateallowlist, usingpgcode.WrongObjectType(SQLSTATE 42809) to match PostgreSQL.Epic: none
Release note (bug fix): WITHIN GROUP on a function that is not an ordered-set aggregate now returns an error matching PostgreSQL.