Skip to content

fix: make it clear what the date-time in the applications overview stands for and clean up some duplication in the ApplicationStatusHero view#5405

Merged
SteKoe merged 2 commits into
codecentric:masterfrom
cdprete:fix/applications-view-time
Jun 12, 2026
Merged

fix: make it clear what the date-time in the applications overview stands for and clean up some duplication in the ApplicationStatusHero view#5405
SteKoe merged 2 commits into
codecentric:masterfrom
cdprete:fix/applications-view-time

Conversation

@cdprete

@cdprete cdprete commented May 31, 2026

Copy link
Copy Markdown
Contributor

Hi guys.

I was about to open a bug request about the date-time in the applications overview page not being kept up to date on every tick of the clock but, by checking the code, I realized it was not its scope.
This PR makes it clear what its scope is (to track down the last time when the applications were updated) by adding some proper text and it also cleans up some duplication in ApplicationStatusHero.

@cdprete cdprete requested a review from a team as a code owner May 31, 2026 13:39
@cdprete cdprete force-pushed the fix/applications-view-time branch 8 times, most recently from 5170f0b to 30195f2 Compare June 6, 2026 12:33
@cdprete

cdprete commented Jun 6, 2026

Copy link
Copy Markdown
Contributor Author

/cc @SteKoe @ulischulte @hzpz

@cdprete cdprete force-pushed the fix/applications-view-time branch 6 times, most recently from 9b81a48 to 2ec9a9f Compare June 11, 2026 17:18
cdprete and others added 2 commits June 12, 2026 11:13
@SteKoe SteKoe force-pushed the fix/applications-view-time branch from ef2ab4d to 02a16f1 Compare June 12, 2026 09:13
@SteKoe SteKoe enabled auto-merge (squash) June 12, 2026 09:13
@SteKoe

SteKoe commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Slightly adjusted the tests. Will be merged when build passes.

@cdprete

cdprete commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

Slightly adjusted the tests. Will be merged when build passes.

Hey @SteKoe, just for learning purposes, what was wrong with them?

@SteKoe

SteKoe commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Slightly adjusted the tests. Will be merged when build passes.

Hey @SteKoe, just for learning purposes, what was wrong with them?

Nothing in particular, they were technically correct. We use a custom render function that provides i18n-functionallity to proof that at least the fallback translation file is updated correctly. We should not test for the i18n key, but the "real" translated value (i.e. human readable). :)

@cdprete

cdprete commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

Slightly adjusted the tests. Will be merged when build passes.

Hey @SteKoe, just for learning purposes, what was wrong with them?

Nothing in particular, they were technically correct. We use a custom render function that provides i18n-functionallity to proof that at least the fallback translation file is updated correctly. We should not test for the i18n key, but the "real" translated value (i.e. human readable). :)

Thanks for the reply. All clear.
I'll keep it in mind for the future. ;)

@SteKoe SteKoe merged commit 6bd5f56 into codecentric:master Jun 12, 2026
1 check passed
@cdprete cdprete deleted the fix/applications-view-time branch June 12, 2026 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants