fix: make it clear what the date-time in the applications overview stands for and clean up some duplication in the ApplicationStatusHero view#5405
Conversation
5170f0b to
30195f2
Compare
|
/cc @SteKoe @ulischulte @hzpz |
9b81a48 to
2ec9a9f
Compare
…ands for and clean up some duplication in the ApplicationStatusHero view
ef2ab4d to
02a16f1
Compare
|
Slightly adjusted the tests. Will be merged when build passes. |
Hey @SteKoe, just for learning purposes, what was wrong with them? |
Nothing in particular, they were technically correct. We use a custom render function that provides i18n-functionallity to proof that at least the fallback translation file is updated correctly. We should not test for the i18n key, but the "real" translated value (i.e. human readable). :) |
Thanks for the reply. All clear. |
Hi guys.
I was about to open a bug request about the date-time in the applications overview page not being kept up to date on every tick of the clock but, by checking the code, I realized it was not its scope.
This PR makes it clear what its scope is (to track down the last time when the applications were updated) by adding some proper text and it also cleans up some duplication in ApplicationStatusHero.