Skip to content

No Jira: Adjust Logging Output#557

Open
mikejritter wants to merge 3 commits into
collectionspace:developfrom
mikejritter:nojira/quiet-logs
Open

No Jira: Adjust Logging Output#557
mikejritter wants to merge 3 commits into
collectionspace:developfrom
mikejritter:nojira/quiet-logs

Conversation

@mikejritter

Copy link
Copy Markdown
Contributor

What does this do?

  • Disable show_sql for hibernate during ant database tasks
  • Change Marshal/Unmarshalling exceptions to debug
  • Adjust datasource config logging

Why are we doing this? (with JIRA link)
No jira. This is some post-upgrade cleanup that I had been wanting to do. For each change:

show_sql - This was nice to have during dev to confirm that the ant task was working as expected and making the expected changes in the db. Now it is simply adding noise to the nightly build logs.

XML Marshalling - Most of the extensions for procedures will end up triggering this, and it's really not a fatal exception. I suppose a WARN could work for it as well, but the exception often makes it look like a red herring. Note that I left the exception in as DEBUG logging is not enabled in prod but it can be removed.

DataSource Config - I didn't really see the benefit of logging the datasource configuration directly to the log, and the logging there was quite noisy. Adjusted to output the filename instead and change log levels accordingly.

How should this be tested? Do these changes have associated tests?

  • For show_sql, ant import can be run. The sql output should no longer be show.
  • For XML Marshalling, create a CollectionObject with some information in the annotation extension. The log should now show up as DEBUG only.
  • For the DataSource Config, I'm not actually sure but I know the UCB tenants trigger this.

Dependencies for merging? Releasing to production?
No dependencies. I did notice some other issues when running tests related to the Apache HttpClient, but I'll make a new ticket for that.

Has the application documentation been updated for these changes?
n/a

Did someone actually run this code to verify it works?
@mikejritter tested the show_sql and xml marshalling logging locally

Have any new security vulnerabilities been handled?
n/a

@mikejritter
mikejritter requested a review from spirosdi July 24, 2026 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants