fix(network): allow inspecting pseudo networks#4953
Open
immanuwell wants to merge 1 commit into
Open
Conversation
sathiraumesh
suggested changes
Jun 10, 2026
immanuwell
force-pushed
the
fix-network-inspect-pseudo-networks
branch
from
9871643 to
79a6561
Compare
Member
https://github.com/containerd/nerdctl/actions/runs/27420363683/job/81044018040?pr=4953 |
AkihiroSuda
reviewed
Jun 12, 2026
| } | ||
|
|
||
| func newPseudoNetworkConfig(name string) (*NetworkConfig, error) { | ||
| confJSON, err := json.Marshal(struct { |
Member
There was a problem hiding this comment.
Isn't this struct already defined in somewhere else?
Contributor
Author
There was a problem hiding this comment.
good point
I switched newPseudoNetworkConfig to reuse the existing cniNetworkConfig, and made nerdctlID / nerdctlLabels omitempty so the synthetic pseudo-network config stays minimal
PTAL
Signed-off-by: immanuwell <pchpr.00@list.ru>
immanuwell
force-pushed
the
fix-network-inspect-pseudo-networks
branch
from
79a6561 to
5a04185
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs #3005
nerdctl network lsshowshostandnone, butnerdctl network inspect hostandnerdctl network inspect nonestill fail. the inspect path asks to allow pseudo networks, but lookup only checked on-disk CNI configs, so these names fell through. kinda awkward.this returns a small synthetic config for pseudo networks in that lookup path, so inspect can render them fine.
repro:
nerdctl network lshostandnonenerdctl network inspect hostno network found matching: host"Name": "host"checks:
go test ./pkg/netutil -count=1go test ./pkg/inspecttypes/dockercompat -count=1go test ./cmd/nerdctl/network -run ^ -count=1