Skip to content

Fix OpenAI optional header casing in locale-sensitive environments #12578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
william-xue wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −0
Open

Fix OpenAI optional header casing in locale-sensitive environments #12578

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/openai-adapters/src/apis/OpenAI.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,10 @@ export class OpenAIApi implements BaseLlmApi {
// Necessary because `new OpenAI()` will throw an error if there is no API Key
apiKey: config.apiKey ?? "",
baseURL: this.apiBase,
defaultHeaders: {
"openai-organization": undefined,
"openai-project": undefined,
},
fetch: customFetch(config.requestOptions),
timeout: config?.requestOptions?.timeout || undefined,
});
Expand Down
13 changes: 13 additions & 0 deletions packages/openai-adapters/src/test/main.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,19 @@ describe("Configuration", () => {
);
});

it("should disable optional OpenAI org/project headers with lowercase keys", () => {
const openai = constructLlmApi({
provider: "openai",
apiKey: "sk-xxx",
apiBase: "https://openrouter.ai/api/v1/",
}) as OpenAIApi;

expect((openai.openai as any)._options.defaultHeaders).toMatchObject({
"openai-organization": undefined,
"openai-project": undefined,
});
});

it("should configure Inception OpenAI client with correct apiBase and apiKey", () => {
const inception = constructLlmApi({
provider: "inception",
Expand Down
Loading