Conversation
bradbeam
reviewed
Jun 9, 2026
git-it127
added a commit
that referenced
this pull request
Jun 10, 2026
Replace the parse_qsl loop in _UrlHasCursorParam with a single dict membership check via parse_qs. parse_qs with keep_blank_values=True covers every shape we accept (cursor=, bare cursor, repeated cursor=) without iterating the rest of the query string. Addresses PR #14 review comment from bradbeam. Co-authored-by: Cursor <cursoragent@cursor.com>
bradbeam
previously approved these changes
Jun 10, 2026
shiv2909
reviewed
Jun 10, 2026
| # final page, which omits it. | ||
| if _UrlHasCursorParam(url): | ||
| current_url = url | ||
| while True: |
There was a problem hiding this comment.
Nit: Should we also add circuit breaker, like max pages could be some number 100? If there is a upstream bug, don't want this to go infinite looop.
shiv2909
reviewed
Jun 10, 2026
| page_map = parser.GetMap(cache_info=scim_body_bytes, data=page_map) | ||
|
|
||
| next_cursor = parser._pagination_metadata.get('nextCursor') | ||
| if not next_cursor: |
There was a problem hiding this comment.
Nit: Should we instead check for none specifically?
if next_cursor is None:
break
shiv2909
previously approved these changes
Jun 10, 2026
shiv2909
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes cursor based pagination logic for SCIM. This also includes a quick unit test fix for sshkey listings