Skip to content

Redo OECD sample to conform to new schema guidelines#6502

Open
kmoscoe wants to merge 32 commits into
datacommonsorg:masterfrom
kmoscoe:samples
Open

Redo OECD sample to conform to new schema guidelines#6502
kmoscoe wants to merge 32 commits into
datacommonsorg:masterfrom
kmoscoe:samples

Conversation

@kmoscoe

@kmoscoe kmoscoe commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

You can see it in action at http://bullie.svl.corp.google.com:8080

Once you approve this, I will fix the DCP version as well.

kmoscoe added 30 commits March 16, 2026 15:25
This reverts commit 6c875ed.
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the OECD sample data to ensure compliance with updated schema guidelines. The changes involve renaming key variables across CSV data files, configuration files, and the variables model configuration file to maintain consistency and improve semantic clarity.

Highlights

  • Schema Compliance: Renamed variables and updated configuration files to align with new schema guidelines, specifically changing 'average_annual_wage' to 'Annual_Average_Wage' and 'gender_wage_gap' to 'Ratio_Average_Wages_To_Male_Average_Wages'.
  • Data Normalization: Updated CSV data files and the variables.mcf file to reflect the new naming conventions and updated the statistical type for the gender wage gap to 'Ratio'.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request renames several variables and provenances across the dataset files to standardize the schema, such as renaming average_annual_wage to Annual_Average_Wage and gender_wage_gap to Ratio_Average_Wages_To_Male_Average_Wages. However, the feedback correctly identifies a critical mathematical inconsistency: the values in the CSV represent the percentage gap rather than a ratio, making the new DCID Ratio_Average_Wages_To_Male_Average_Wages misleading. Additionally, dcid:Ratio is pointed out as an invalid statType in Data Commons. It is recommended to revert the DCID to a name representing the wage gap (e.g., GenderWageGap) and remove the invalid statType.

Comment thread custom_dc/sample/variables.mcf Outdated
Comment thread custom_dc/sample/gender_wage_gap.csv Outdated
@kmoscoe
kmoscoe requested a review from carojahn July 23, 2026 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant