Redo OECD sample to conform to new schema guidelines#6502
Conversation
This reverts commit 6c875ed.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the OECD sample data to ensure compliance with updated schema guidelines. The changes involve renaming key variables across CSV data files, configuration files, and the variables model configuration file to maintain consistency and improve semantic clarity. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request renames several variables and provenances across the dataset files to standardize the schema, such as renaming average_annual_wage to Annual_Average_Wage and gender_wage_gap to Ratio_Average_Wages_To_Male_Average_Wages. However, the feedback correctly identifies a critical mathematical inconsistency: the values in the CSV represent the percentage gap rather than a ratio, making the new DCID Ratio_Average_Wages_To_Male_Average_Wages misleading. Additionally, dcid:Ratio is pointed out as an invalid statType in Data Commons. It is recommended to revert the DCID to a name representing the wage gap (e.g., GenderWageGap) and remove the invalid statType.
You can see it in action at http://bullie.svl.corp.google.com:8080
Once you approve this, I will fix the DCP version as well.