#2168: repository remote feature - #2198
Conversation
|
Quang Anh Le seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Coverage Report for CI Build 29991593234Coverage increased (+0.02%) to 72.516%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions42 previously-covered lines in 5 files lost coverage.
Coverage Stats💛 - Coveralls |
|
@hohwille If the remotes are automatically created from the |
|
Hi @QuangAnhLe, thanks for your contribution, a few things that stand out:
Also please replace "TodoIssueID" in the PR description with the link to #2168 and adjust the PR title to the form #2168: «brief summary». And the CLA still needs to be signed before this can be merged. |
| void addRemote(Path repository, String name, String url); | ||
| /** | ||
| * Commits the staged changes in the given repository. |
There was a problem hiding this comment.
| void addRemote(Path repository, String name, String url); | |
| /** | |
| * Commits the staged changes in the given repository. | |
| void addRemote(Path repository, String name, String url); | |
| /** | |
| * Commits the staged changes in the given repository. |
There was a problem hiding this comment.
There should be a blank line after the opening brace('{'). Also the spaces in the comments are a bit off.
This PR fixes TodoIssueID
Implemented changes:
RepositoryRemoterecord ( similar toRepositotyLink)git_remoteproperty parsing toRepositoryPropertiesremotesfield toRepositoryConfigitContextinterface and implementationRepositoryCommandletafter cone/pull and before linkingTesting instructions
Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:
Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internalChecklist for tool commandlets
Have you added a new
«tool»as commandlet? There are the following additional checks:«tool»«TOOL»_VERSIONand«TOOL»_EDITIONare honored by your commandlet