#2173: store JetBrains vmoptions under $IDE_HOME/.ide/<ide>/<workspace>#2208
Draft
quando632 wants to merge 6 commits into
Draft
#2173: store JetBrains vmoptions under $IDE_HOME/.ide/<ide>/<workspace>#2208quando632 wants to merge 6 commits into
quando632 wants to merge 6 commits into
Conversation
…orkspace> + cleanup migration
This was referenced Jul 24, 2026
Collaborator
Coverage Report for CI Build 30092296095Coverage increased (+0.01%) to 72.572%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions11 previously-covered lines in 3 files lost coverage.
Coverage Stats💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes part of #2173 (part of #2142)
Moves the JetBrains VM options out of the workspace into
$IDE_HOME/.ide/«ide»/«workspace»for IntelliJ, PyCharm and Android Studio, solved once in their shared superclass.Scope note (important)
During implementation the
.ideafolder and the*.propertiesfiles turned out to be entangled with the workspace-template-merge mechanism / IntelliJ's project-root convention (andidea.propertiesis an empty template merged into the workspace relocating only its env var gives no benefit). So this PR intentionally covers only the vmoptions, which are the one metadata written directly by code and thus cleanly relocatable..idea+*.propertiesare split out into a dedicated design spike (see follow-up issue) as agreed on #2142.Implemented changes
IdeaBasedIdeToolCommandlet.runTool: the.«prefix».vmoptionsfile is now written togetIdeMetadataPath()instead of the workspace (env var points at the same new path). Covers IntelliJ (.idea.vmoptions), PyCharm (.pycharm.vmoptions) and Android Studio (.studio.vmoptions) via the shared superclass.Mig202608002(target2026.08.002): backs up the stale.*.vmoptionsfiles from every workspace (they are regenerated at the new location from the«IDE»_VM_ARGSvariable on next launch). Registered inIdeMigrator.IntellijTest,PycharmTest,AndroidStudioTestto assert the new location; addedMig202608002Test.Testing instructions
cd cli && mvn -Dtest=IntellijTest,PycharmTest,AndroidStudioTest,Mig202608002Test,IdeMigratorTest testall pass.INTELLIJ_VM_ARGSin your project, runide intellij, verify.idea.vmoptionsis created under$IDE_HOME/.ide/intellij/«workspace»/and not in the workspace.Checklist for this PR
mvn clean testlocally all tests pass and build is successful (ran the affected tests)#«issue-id»: «brief summary»In Progressand assigned to youCoordination note
IdeMigratorrequires strictly ascending migration versions. VSCode subtask #2201 addsMig202608001; this PR addsMig202608002. On merge, ensure they are registered in ascending order (001 before 002).