chore: migrate motoko/threshold-schnorr to icp-cli#1367
Open
marc0olo wants to merge 14 commits into
Open
Conversation
Replace dfx.json with icp.yaml, move source to backend/, update
mops.toml to moc 1.9.0 + core 2.5.0 + ic 4.0.0, replace inline
actor type with import { ic } "mo:ic", add icp-cli Makefile test
target and CI workflow.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…eck --fix Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…t.sh Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…chnorr - @noble/ed25519 v2.x: sync verify(), no sha512Sync setup needed - BIP340/BIP341: tiny-secp256k1.verifySchnorr requires exactly 32 bytes; use 'hello world of BIP340 secp256k1' (32 ASCII chars) - Switch inline node scripts from dynamic import() to require() Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…frontend) No backend.did is committed and no frontend needs bindings, so this section is not applicable. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ng-apps URL Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
raymondk
approved these changes
Jun 11, 2026
alin-at-dfinity
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates
motoko/threshold-schnorrfrom dfx to icp-cli.dfx.jsonwithicp.yaml(@dfinity/motoko@v5.0.0)src/schnorr_example_motoko/→backend/; add missingBlob,Principal,Text,OptionimportsICactor type withimport { ic } "mo:ic"; applymops check --fixmops.toml: moc 1.9.0, core 2.5.0, ic 4.0.0Makefilewith 5 tests (format checks for both key types + cryptographic verification viatest.sh)test.shverifying ed25519 (@noble/ed25519), BIP340 and BIP341 (tiny-secp256k1,bitcoinjs-lib); use 32-byte message for BIP340package.json; removedfx_test_keyreferencesicp-dev-env-motoko:0.3.2)chain-key cryptographyconcept page; remove outdatedbuilding-appsURL; remove inapplicable "Updating the Candid interface" section (backend-only, no frontend)Test plan
motoko-threshold-schnorrCI passes🤖 Generated with Claude Code