chore: migrate motoko/threshold-ecdsa to icp-cli#1368
Merged
Conversation
Replace dfx-based tooling with icp-cli: swap dfx.json for icp.yaml,
move source files to backend/ layout, replace inline IC actor type with
import { ic } "mo:ic" (v4.0.0), update mops.toml to moc 1.9.0 / core
2.5.0, add Makefile test target, add CI workflow, and remove dfx
artifacts (BUILD.md, .devcontainer, package.json, test.sh).
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…frontend) No backend.did is committed and no frontend needs bindings, so this section is not applicable. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ng-apps URL Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
raymondk
approved these changes
Jun 11, 2026
alin-at-dfinity
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates
motoko/threshold-ecdsafrom dfx to icp-cli.dfx.jsonwithicp.yaml(@dfinity/motoko@v5.0.0)src/ecdsa_example_motoko/→backend/; rename utility modules tobackend/Hex.mo,backend/SHA256.moICactor type withimport { ic } "mo:ic"mops.toml: moc 1.9.0, core 2.5.0, ic 4.0.0; applymops check --fixMakefilewith 3 tests (format checks + secp256k1 cryptographic verification viatest.sh)test.shwith secp256k1ecdsaVerifyend-to-end signature check; addpackage.jsondfx_test_keyreferencesicp-dev-env-motoko:0.3.2)chain-key cryptographyconcept page; remove outdatedbuilding-appsURL; remove inapplicable "Updating the Candid interface" section (backend-only, no frontend)Test plan
motoko-threshold-ecdsaCI passes🤖 Generated with Claude Code