[std.complex] Tweak signatures for complex and constructor#11052
Merged
Conversation
Inline constraints. Rename constructor parameters to be clearer.
| */ | ||
| auto complex(R)(const R re) @safe pure nothrow @nogc | ||
| if (is(R : double)) | ||
| auto complex(R : double)(const R re) @safe pure nothrow @nogc |
Contributor
Author
There was a problem hiding this comment.
@thewilsonator is(real : double) is true, on my system (and https://run.dlang.io/), even though real is 16 bytes and double is 8. That seems wrong.
Contributor
There was a problem hiding this comment.
It's not. All floating point types implicitly convert to any other floating point type. It IS weird, but it's intended.
This comment was marked as resolved.
This comment was marked as resolved.
thewilsonator
approved these changes
Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inline constraints.
Rename constructor parameters to be clearer.
This increases consistency, and I doubt anyone was using named parameters for the ctor.