docs: fix per-model Shift+Tab thinking-level cycle description#3111
Conversation
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟡 NEEDS ATTENTION
This documentation fix correctly changes the cycling description from "provider-specific" to "model-specific". Two inconsistencies were found in the updated examples on line 335.
…gpt-5.2+ Address two reviewer comments on PR #3111: 1. Remove the Anthropic Sonnet cycle example (none→low→medium→high→none) which implied effort-string cycling works on Sonnet 4.5. Per the warning at line 123 and the code in pkg/modelinfo/thinking_levels.go, effort strings are only accepted by Opus 4.6+ (adaptive thinking); Sonnet 4.5 and earlier require integer token budgets. Cycling through string levels on such models has no effect — clarify this instead. 2. Retain gpt-5.2+ in the example. The openAISupportsXHighEffort() function in thinking_levels.go explicitly gates xhigh on gpt-5.x with minor version ≥ 2, and lines 27, 40, and 61 of this same doc already document this per-version distinction — the example is consistent with the rest of the page.
|
Addressed both reviewer comments in commit 92c42de: Issue 1 (Anthropic Sonnet cycle): Removed the separate Issue 2 (gpt-5.2+): Retained |
Documentation changes
Updates `docs/guides/thinking/index.md` to fix the description of how the TUI's Shift+Tab thinking-level cycling works after #3097 changed the behaviour from per-provider to per-model.
What was wrong
The "Changing Thinking Level at Runtime" section said:
After #3097, cycling is model-specific — each model only offers the levels its API actually accepts. The old OpenAI example implied every OpenAI reasoning model cycles through `xhigh`, but that's only true for gpt-5.2+; gpt-5, gpt-5.1, and the o-series all top out at `high`.
What was fixed
The bullet now reads:
Commits
818742d1PRs reviewed and found up to date