Fix Go-to-Definition for provided constructors without definition location#19917
Open
T-Gro wants to merge 5 commits into
Open
Fix Go-to-Definition for provided constructors without definition location#19917T-Gro wants to merge 5 commits into
T-Gro wants to merge 5 commits into
Conversation
Adds two regression tests in Project25 that exercise GetDeclarationLocation on a provided constructor call (Item.CtorGroup whose head is ProvidedMeth). The constructor's MyType has no TypeProviderDefinitionLocationAttribute, so the current implementation returns DeclNotFound (ProvidedMember ".ctor") instead of jumping to the user's ype T = MyType line. A subsequent commit will fix this in SymbolHelpers.fs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
… GREEN) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
… range (#5538) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
❗ Release notes requiredYou can open this PR in browser to add release notes: open in github.dev
|
github-actions
Bot
added
the
AI-Tooling-Check-Bypassed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5538
When a provided constructor (or property/event) lacks a
TypeProviderDefinitionLocationAttribute, Go-to-Definition now fallsback to the declaring type's range instead of returning
DeclNotFound.