Add OpenBSD support in CPalThread#129057
Merged
jkotas merged 3 commits intoJun 6, 2026
Merged
Conversation
dotnet-policy-service
Bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @VSadov |
jkotas
reviewed
Jun 6, 2026
jkotas
reviewed
Jun 6, 2026
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
am11
approved these changes
Jun 6, 2026
jkotas
approved these changes
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add OpenBSD support for
CPalThread::GetStackBase()andCPalThread::GetStackLimit().OpenBSD does not have
pthread_attr_get_nporpthread_getattr_npto get the current thread's stack attributes.Instead there is a standalone function pthread_stackseg_np that does the same via stack_t. Since we do not actually need a standard pthread attr in this case I put this case inside a
TARGET_OPENBSDcheck similar to macOS.I know that the preferred means of upstreaming the rest of OpenBSD support is to do it all at once but I'm fairly stuck now and you can see my most recent comments here.
So I decided to send this PR for now while I try to figure out next steps for the port.
Contributes to #124911