Skip to content

[Wasm / RyuJit]: don't mark CORINFO_HELP_GETREFANY pure on wasm #129060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AndyAyersMS wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −2
Open

[Wasm / RyuJit]: don't mark CORINFO_HELP_GETREFANY pure on wasm #129060

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/coreclr/jit/utils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1596,9 +1596,12 @@ void HelperCallProperties::init()
break;

// GETREFANY is pure up to the value of the struct argument. We
// only support that when it is not an implicit byref.
// only support that when it is not an implicit byref. The
// TypedReference struct (two pointers) is passed by implicit
// byref on win-x64 and on wasm (the wasm ABI passes any struct
// without a single scalar lowering by reference).
case CORINFO_HELP_GETREFANY:
#ifndef WINDOWS_AMD64_ABI
#if !defined(WINDOWS_AMD64_ABI) && !defined(TARGET_WASM)
isPure = true;
#endif
break;
Expand Down
Loading