Skip to content

ECC-2282: Feature/hydrology c3s#496

Merged
joobog merged 4 commits into
developfrom
feature/hydrology_c3s
Jun 18, 2026
Merged

ECC-2282: Feature/hydrology c3s#496
joobog merged 4 commits into
developfrom
feature/hydrology_c3s

Conversation

@rdosinski

Copy link
Copy Markdown
Collaborator

Description

This PR is to adapt the MARS namespace for C3S hydrology data, classes gh and eh. In the current implementation for class gh and class eh, stattype was always available and aliased into the mars namespace. It is only needed for streams msmm and rfsd. The original stream mmsf is for sub-daily and daily parameters, so mmsf must be changed to msmm which contains the monthly averages. step and fcmonth is not needed in stream rfsd, the statistics are described using stattype and timespan.

The local section 12 and 16 contain already the meta key marsForecastMonth, so it only needs to be recalculated for local sections other than 12 and 16.

Please merge this branch into develop for the future 2.48.0 release. Please also cherry-pick the following commits into hotfix/2.47.2:

d65af02
36213d4
ba3dc09

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@joobog joobog added the approved-for-ci Approved to run CI on ECMWF machines label Jun 17, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.16%. Comparing base (fa764a8) to head (5b5ee8b).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #496   +/-   ##
========================================
  Coverage    88.16%   88.16%           
========================================
  Files          854      854           
  Lines        63582    63582           
  Branches     11301    11301           
========================================
  Hits         56056    56056           
  Misses        7526     7526           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joobog joobog merged commit 0de418f into develop Jun 18, 2026
953 of 1054 checks passed
@joobog joobog deleted the feature/hydrology_c3s branch June 18, 2026 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-for-ci Approved to run CI on ECMWF machines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants