ECC-2282: Feature/hydrology c3s#496
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #496 +/- ##
========================================
Coverage 88.16% 88.16%
========================================
Files 854 854
Lines 63582 63582
Branches 11301 11301
========================================
Hits 56056 56056
Misses 7526 7526 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is to adapt the MARS namespace for C3S hydrology data, classes gh and eh. In the current implementation for class gh and class eh, stattype was always available and aliased into the mars namespace. It is only needed for streams msmm and rfsd. The original stream mmsf is for sub-daily and daily parameters, so mmsf must be changed to msmm which contains the monthly averages. step and fcmonth is not needed in stream rfsd, the statistics are described using stattype and timespan.
The local section 12 and 16 contain already the meta key marsForecastMonth, so it only needs to be recalculated for local sections other than 12 and 16.
Please merge this branch into develop for the future 2.48.0 release. Please also cherry-pick the following commits into hotfix/2.47.2:
d65af02
36213d4
ba3dc09
Contributor Declaration
By opening this pull request, I affirm the following: