Fixed all the tests + Added (true) Visual Mode#130
Merged
Conversation
Test number egaga#17 now successful
When pressing j or h, the cursor should stay on the same column. Even if a line didn't have enough characters, the cursor should adapt for that line than go back to same column.
There is a problem with the w, e, and b commands : they follow "WORDS" and not "words"
- `init_testing.js`-> `$()` was missing, adding it fixed a lot of tests - `testengine.js`-> Clean leftovers of last test [improved `setup`] - `commands.js`-> After `dd`, cursor go to the start of next line - `executor.js`-> Improve `removeBetween` funtion
- `commands.js`-> updated `vim_shifted_j()` - `executor.js` -> added utilities for more clarity
- Factorized the `insertNewLine[Before/After]Cursor` - To be used in other commands (check next commits)
- Simulated tests in Vim, observed results and updated the unit tests
- All Tests are now green - Visual Mode works well in sandbox - All visual mode logic in one file
Owner
Collaborator
|
Thank you for the contribution! I appreciate
I looked the code but did not spend time to verify all logic. There is problems with tests but they were small so I accepted anyway: 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I enjoyed the tutorial, but felt sad that the sandbox doesn't work properly. So I decided to contribute.
Things done :
executor.js).Results :
Things to be done :
PS :
I've just noticed the
tasks.txtfile. So, my next steps will be to follow the tasks.Additionally, now that i understood the whole project. I am ready to migrate it to Typescript. That would be a sensible and empowering choice.
On standby.
Note :
AI-agents fail maintaining legacy code : they write (3x) more code than needed, and still introduce errors.
Maybe Typescript would allow them contribute better.