Skip to content

feat(node): use postage snapshot on --resync unless skipped#5519

Merged
gacevicljubisa merged 2 commits into
masterfrom
feat/resync-uses-postage-snapshot
Jun 25, 2026
Merged

feat(node): use postage snapshot on --resync unless skipped#5519
gacevicljubisa merged 2 commits into
masterfrom
feat/resync-uses-postage-snapshot

Conversation

@gacevicljubisa

@gacevicljubisa gacevicljubisa commented Jun 23, 2026

Copy link
Copy Markdown
Member

Checklist

  • I have read the coding guide.
  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

--resync on an existing batch store rescanned the whole postage contract from the chain, because the snapshot only loaded when no store existed. Since a resync wipes the store anyway, treat it as "no store" and rebuild from the embedded snapshot on --resync too, unless --skip-postage-snapshot is set.

Decision extracted into useEmbeddedSnapshot with a table test.

Open API Spec Version Changes (if applicable)

Motivation and Context (Optional)

Related Issue (Optional)

Screenshots (if appropriate):

AI Disclosure

  • This PR contains code that has been generated by an LLM.
  • I have reviewed the AI generated code thoroughly.
  • I possess the technical expertise to responsibly review the code generated in this PR.

@gacevicljubisa gacevicljubisa marked this pull request as ready for review June 23, 2026 13:45
@gacevicljubisa gacevicljubisa merged commit 5c739d1 into master Jun 25, 2026
20 of 21 checks passed
@gacevicljubisa gacevicljubisa deleted the feat/resync-uses-postage-snapshot branch June 25, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants