Skip to content

fix(firestore,windows): reply on platform thread to prevent warnings#18459

Merged
Lyokone merged 1 commit into
mainfrom
fix/17073
Jul 17, 2026
Merged

fix(firestore,windows): reply on platform thread to prevent warnings#18459
Lyokone merged 1 commit into
mainfrom
fix/17073

Conversation

@Lyokone

@Lyokone Lyokone commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Description

Firestore Query.get() completions on Windows replied to Flutter directly from Firebase worker threads. Repeated paginated reads amplified this unsafe platform-channel path, which can cause data loss or crashes.

This routes both successful query snapshots and query errors through the existing Windows platform-thread dispatcher before sending the Pigeon reply.

Related Issues

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@Lyokone
Lyokone merged commit cfeddb1 into main Jul 17, 2026
56 of 59 checks passed
@Lyokone
Lyokone deleted the fix/17073 branch July 17, 2026 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[cloud_firestore]: Firestore Crash on Windows When Fetching Large Amounts of Data in Batches

3 participants