Skip to content

Add route for configuration profile assets#48133

Merged
melpike merged 2 commits into
mainfrom
melpike-patch-5
Jun 25, 2026
Merged

Add route for configuration profile assets#48133
melpike merged 2 commits into
mainfrom
melpike-patch-5

Conversation

@melpike

@melpike melpike commented Jun 23, 2026

Copy link
Copy Markdown
Member

Related issue: Resolves #38986

Summary by CodeRabbit

  • New Features
    • Added a new convenience redirect route for GET /learn-more-about/configuration-profile-assets, sending users to the related configuration profile assets article section.

@fleet-release
fleet-release requested a review from eashaw June 23, 2026 22:02

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 303e867b-08e9-421f-a4e8-ea48dace8de6

📥 Commits

Reviewing files that changed from the base of the PR and between 66efbf0 and 51c1a1e.

📒 Files selected for processing (1)
  • website/config/routes.js
💤 Files with no reviewable changes (1)
  • website/config/routes.js

Walkthrough

A new GET redirect route is added to website/config/routes.js mapping /learn-more-about/configuration-profile-assets to /articles/custom-os-settings#apple-declarations-ddm.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description only links an issue and omits the required template sections like testing and checklist details. Add the missing template sections, especially testing, checklist items, and any relevant implementation notes.
Linked Issues check ⚠️ Warning The change only adds a redirect route and does not implement the DDM profile and asset support requested in #38986. Implement the requested Apple DDM profile/asset functionality, or narrow the linked issue if this PR is only a documentation redirect.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the only code change: adding a route for configuration profile assets.
Out of Scope Changes check ✅ Passed The single redirect route appears aligned with the documentation/navigation scope and introduces no unrelated changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch melpike-patch-5

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@melpike
melpike merged commit d5d95f7 into main Jun 25, 2026
12 checks passed
@melpike
melpike deleted the melpike-patch-5 branch June 25, 2026 15:41
JordanMontgomery pushed a commit that referenced this pull request Jun 26, 2026
<!-- Add the related story/sub-task/bug number, like Resolves #123, or
remove if NA -->
**Related issue:** Resolves #38986


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **New Features**
* Added a new convenience redirect route for `GET
/learn-more-about/configuration-profile-assets`, sending users to the
related configuration profile assets article section.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support all Apple declaration (DDM) profiles and assets

2 participants