fix: replace extract-zip with node-stream-zip to fix Node 24.16.0 hang#831
Merged
Conversation
cd6e784 to
b6d564c
Compare
extract-zip@2.0.1 (via yauzl@2.10.0 / fd-slicer@1.1.0) hangs on Node.js 24.16.0+ due to a stream regression (nodejs/node#63487). This caused craft publish to silently exit after downloading artifacts. Replace with node-stream-zip@1.15.0 which has zero dependencies and works correctly on all Node.js versions.
b6d564c to
3566840
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
extract-zip@2.0.1(viayauzl@2.10.0/fd-slicer@1.1.0) hangs on Node.js 24.16.0+ due to a stream regression (nodejs/node#63487). The root cause is PR nodejs/node#61098 ("stream: propagate destruction in duplexPair") which interacts badly withfd-slicer's old-style stream implementation.This caused
craft publishto silently exit with code 0 after downloading artifacts, without actually publishing anything. The issue also affects Node.js >=26.1.0.Affected ecosystem: extract-zip, Playwright, Puppeteer, Electron Forge, Cypress — all of which have had to work around or replace
extract-zip.Fix
Replace
extract-zipwithnode-stream-zip@1.15.0:StreamZip.asyncChanges
src/utils/system.tsextract-zipimport withnode-stream-zip; rewroteextractZipArchive()to useStreamZip.asyncwithmkdir(extract-zip created the output dir automatically, node-stream-zip doesn't) andtry/finallyfor cleanuppackage.jsonextract-zip,@types/extract-zip(deprecated stub); addednode-stream-zip@^1.15.0Net result: -9 packages, +1 package. All 24 system tests pass.