fix(sanic): Gate url.full, url.path, and http.query behind send_default_pii#6663
Merged
Conversation
…lt_pii Move url.full, url.path, and http.query span attributes behind the send_default_pii flag to avoid leaking PII in Sanic request spans. Consistent with the same fix applied to aiohttp, wsgi, and asgi. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Codecov Results 📊✅ 89965 passed | ⏭️ 6300 skipped | Total: 96265 | Pass Rate: 93.46% | Execution Time: 322m 47s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2402 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 89.93% 89.90% -0.03%
==========================================
Files 192 192 —
Lines 23784 23786 +2
Branches 8210 8212 +2
==========================================
+ Hits 21389 21384 -5
- Misses 2395 2402 +7
- Partials 1342 1343 +1Generated by Codecov Action |
alexander-alderman-webb
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
url.full,url.path, andhttp.queryspan attributes on Sanic request spans are now only set whensend_default_pii=True. Previouslyurl.fullwas always set, which could leak sensitive path or query parameter values.This matches the same fix already applied to the aiohttp, wsgi, and asgi integrations.
Fixes PY-2555
Fixes #6660