feat(client-reports): Client report protocol#1132
Closed
szokeasaurusrex wants to merge 2 commits into
Closed
Conversation
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Features
- Client report protocol ([#1132](https://github.com/getsentry/sentry-rust/pull/1132))If none of the above apply, you can opt out of this check by adding |
szokeasaurusrex
force-pushed
the
szokeasaurusrex/client-report-protocol
branch
5 times, most recently
from
208a2b1 to
ad5340d
Compare
szokeasaurusrex
changed the base branch from
master
to
szokeasaurusrex/move-batcher-under-client
szokeasaurusrex
force-pushed
the
szokeasaurusrex/move-batcher-under-client
branch
from
32b9805 to
ff22f25
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/client-report-protocol
branch
from
ad5340d to
c5b2a2a
Compare
This will allow us to add additional construction options, either to all transports or to individual transports, in the future without breaking the public API. This will be useful in #1004, as we will need to provide transports with a handle to record data losses. For users who use a custom transport/transport factory, this change may produce a minor behavior breakage, as the `&ClientOptions` received by the `create_transport` method (or the closure, in the case of transport factories which are just closures) will no longer contain all of the options set when init-ing the SDK, only those options which are also present in `TransportOptions`. As the API remains fully compatible, however, we are not considering this to be a public API breakage, and will release these changes in a minor/patch release. References [#1004](#1004) References [RUST-156](https://linear.app/getsentry/issue/RUST-156/record-transport-drops-and-attach-client-report-envelopes)
Added WIP client report protocol. Resolves [#1001](#1001) Resolves [RUST-153](https://linear.app/getsentry/issue/RUST-153/add-client-report-protocol-envelope-item-support-in-sentry-types)
szokeasaurusrex
force-pushed
the
szokeasaurusrex/client-report-protocol
branch
from
c5b2a2a to
66c55a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added WIP client report protocol.
Let's wait with reviewing, I am going to build the rest of the client reports stuff on top of this, and will likely change things around depending here depending on what we end up needing here.
Resolves #1001
Resolves RUST-153